Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community - add trustarc for cookies #4865

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Community - add trustarc for cookies #4865

merged 2 commits into from
Mar 25, 2024

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Feb 21, 2024

Issue: AAH-2163, AAH-2611, AAP-10043

This should add a trustarc script, cookie preferences, and cookie banner; in community mode container only.

20240315002019
20240315002049
20240315002059

todo: prod witout .dev and -test

EDIT: updated to prod version

@himdel himdel added the community comunity mode feature label Feb 21, 2024
@ShaiahWren ShaiahWren self-assigned this Feb 21, 2024
@himdel himdel marked this pull request as ready for review February 28, 2024 18:39
@himdel himdel force-pushed the trustarc branch 2 times, most recently from fbd23f2 to 6f33d30 Compare March 1, 2024 05:05
@himdel
Copy link
Collaborator Author

himdel commented Mar 11, 2024

All the ways I could test it locally don't work - nothing new appears in the ui, depending on the domain & data-domain config, I either get CORS errors loading the script, or a country error, or nothing.

Moving to draft pending further input.

EDIT: Fixed, now using the right script

@himdel himdel marked this pull request as draft March 11, 2024 15:04
@himdel himdel marked this pull request as ready for review March 15, 2024 00:19
@himdel
Copy link
Collaborator Author

himdel commented Mar 25, 2024

Merging so that this can be tested once deployment issues are resolved.

@himdel himdel merged commit 5c0d635 into ansible:master Mar 25, 2024
18 checks passed
@himdel himdel deleted the trustarc branch March 25, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community comunity mode feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants