Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SortableList and ColumnList 去除初始化逻辑,支持 id 通过 getId 方法获取 #71

Merged
merged 8 commits into from
Aug 31, 2023

Conversation

rdmclin2
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 30, 2023

🎊 PR Preview 59f1b55 has been successfully built and deployed to https://ant-design-pro-editor-preview-pr-71.surge.sh

🕐 Build time: 128.273s

🤖 By surge-preview

@rdmclin2 rdmclin2 changed the title fix: SortableList and ColumnList 初始化逻辑 [WIP] fix: SortableList and ColumnList 初始化逻辑 Aug 30, 2023
@rdmclin2 rdmclin2 changed the title [WIP] fix: SortableList and ColumnList 初始化逻辑 feat: SortableList and ColumnList 去除初始化逻辑,支持 id 通过 getId 方法获取 Aug 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage: 87.14% and project coverage change: -0.04% ⚠️

Comparison is base (fe954db) 87.66% compared to head (59f1b55) 87.63%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   87.66%   87.63%   -0.04%     
==========================================
  Files         335      335              
  Lines       21629    21619      -10     
  Branches      972      967       -5     
==========================================
- Hits        18961    18945      -16     
- Misses       2668     2674       +6     
Files Changed Coverage Δ
src/SortableList/demos/renderItem.tsx 73.84% <0.00%> (ø)
src/SortableList/hooks/useSortableList.ts 91.66% <0.00%> (-1.30%) ⬇️
src/SortableList/store/store.ts 50.87% <14.28%> (-1.96%) ⬇️
src/SortableList/demos/getId.tsx 93.33% <93.33%> (ø)
src/ColumnList/ColumnList.tsx 96.66% <95.12%> (-1.61%) ⬇️
src/ColumnList/ColumnItem.tsx 96.25% <100.00%> (+0.02%) ⬆️
src/ColumnList/demos/actions.tsx 96.82% <100.00%> (ø)
src/ColumnList/demos/column.tsx 98.38% <100.00%> (ø)
src/ColumnList/demos/controlled.tsx 95.00% <100.00%> (ø)
src/ColumnList/demos/creatorButtonProps.tsx 95.90% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ONLY-yours ONLY-yours merged commit a43ce91 into main Aug 31, 2023
4 checks passed
@ONLY-yours ONLY-yours deleted the feat/sortable-list branch August 31, 2023 07:55
@github-actions
Copy link

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants