Fix async step persistence for synchronous actions - #895
Merged
jernejfrank merged 3 commits intoAug 29, 2026
Conversation
jernejfrank
reviewed
Aug 29, 2026
jernejfrank
left a comment
jernejfrank
left a comment
Contributor
There was a problem hiding this comment.
Great, just the one minor thing to keep the code clean. Looks good otherwise
| return self._step( | ||
| output = self._step( | ||
| inputs=inputs, _run_hooks=False | ||
| ) # Skip hooks as we already ran all of them/will run all of them in this function's finally |
Contributor
There was a problem hiding this comment.
This comment is out of place now, would be good to document inline here as well that we want to run async hooks for things like async persisters saving state of sync steps
Contributor
|
Could you also run pre-commit hooks please? |
Contributor
Author
|
Sure! I’ll clarify the comment inline and run the pre-commit hooks, then push an update. Thanks! |
jernejfrank
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
Application.astep()executes a synchronous action, it now forwards the action result and updated state returned by_step()to the async post-step hooks.This prevents async persisters from saving the pre-step state as
completedand ensures lifecycle hooks observe the actual result and state.Testing
tests/core/test_application.py: 138 passedtests/coreexcluding optional Graphviz display tests: 390 passedflake8 burr/core/application.py tests/core/test_application.pyThe two Graphviz display tests require the optional
graphvizPython package, which is not installed in the test environment.