Feat: Add support for stickyness policy - #88
Open
vishesh92 wants to merge 1 commit into
Open
Conversation
vishesh92
marked this pull request as draft
December 2, 2025 09:17
vishesh92
force-pushed
the
feat-add-stickyness-policy
branch
from
December 12, 2025 07:33
f25a1e7 to
207f378
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 50.05% 52.58% +2.53%
==========================================
Files 4 4
Lines 975 1065 +90
==========================================
+ Hits 488 560 +72
- Misses 473 490 +17
- Partials 14 15 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vishesh92
force-pushed
the
feat-add-stickyness-policy
branch
from
August 20, 2026 09:26
207f378 to
6b74579
Compare
vishesh92
marked this pull request as ready for review
August 20, 2026 09:26
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for configuring CloudStack Load Balancer stickiness policy via Kubernetes Service annotations (fixing the request in #75), and updates module dependencies to use a CloudStack Go SDK version that supports the required stickiness-policy API parameters.
Changes:
- Introduces Service annotations for stickiness method name + params and reconciles stickiness policies during
EnsureLoadBalancer. - Extends load balancer discovery to also fetch existing stickiness policies for rules.
- Bumps
github.com/apache/cloudstack-go/v2tov2.19.1and updates Go module dependencies accordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| cloudstack_loadbalancer.go | Adds stickiness annotations, policy reconciliation logic, and stickiness policy listing/CRUD. |
| go.mod | Bumps CloudStack Go SDK to v2.19.1 and adjusts dependency classification. |
| go.sum | Updates checksums for the bumped CloudStack Go SDK version. |
Suppressed comments (2)
cloudstack_loadbalancer.go:833
CreateLBStickinessPolicyresponse is assumed to contain at least oneStickinesspolicyentry; if the API returns an empty slice this will panic. Add a defensive check and return an explicit error (and drop the commented-out return).
return &cloudstack.LBStickinessPolicyStickinesspolicy{
Methodname: stickynessPolicy.Stickinesspolicy[0].Methodname,
Params: stickynessPolicy.Stickinesspolicy[0].Params,
Id: stickynessPolicy.Stickinesspolicy[0].Id,
Name: stickynessPolicy.Stickinesspolicy[0].Name,
cloudstack_loadbalancer.go:1282
parseStickynessParamstrims the fullkey=valuetoken but not the key/value themselves, so annotations like "cookie = abc" will produce a key of "cookie " and won’t match expected params. Trim both sides when populating the map.
if len(parts) == 2 {
params[parts[0]] = parts[1]
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+501
to
+503
| if len(lbStickinessPolicies.LBStickinessPolicies) > 0 { | ||
| lb.stickynessPolicies[lbRule.Id] = &lbStickinessPolicies.LBStickinessPolicies[0].Stickinesspolicy[0] | ||
| } |
Comment on lines
+726
to
+731
| for key, value := range stickynessPolicy.Params { | ||
| if stickynessMethodParams[key] != value { | ||
| klog.V(4).Infof("sticky policy param %v does not match: %v", key, value) | ||
| return stickynessPolicy, true, nil | ||
| } | ||
| } |
Comment on lines
+60
to
+61
| ServiceAnnotationLoadBalancerStickynessMethodName = "service.beta.kubernetes.io/cloudstack-load-balancer-stickyness-method-name" | ||
| ServiceAnnotationLoadBalancerStickynessParam = "service.beta.kubernetes.io/cloudstack-load-balancer-stickyness-method-param" |
Comment on lines
+691
to
+695
| func (lb *loadBalancer) checkStickynessPolicy(lbRule *cloudstack.LoadBalancerRule, service *corev1.Service) (*cloudstack.LBStickinessPolicyStickinesspolicy, bool, error) { | ||
| stickynessPolicy := lb.stickynessPolicies[lbRule.Id] | ||
| stickynessMethodName := getStringFromServiceAnnotation(service, ServiceAnnotationLoadBalancerStickynessMethodName, "") | ||
| stickynessMethodParam := getStringFromServiceAnnotation(service, ServiceAnnotationLoadBalancerStickynessParam, "") | ||
| stickynessMethodParams := parseStickynessParams(stickynessMethodParam) |
vishesh92
force-pushed
the
feat-add-stickyness-policy
branch
from
August 27, 2026 13:15
6b74579 to
95d6b1d
Compare
vishesh92
force-pushed
the
feat-add-stickyness-policy
branch
from
August 31, 2026 06:15
95d6b1d to
63947d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs changes in this PR: apache/cloudstack-go#133
Fixes #75