Add datasource for security groups - #328
Open
bddvlpr wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @bddvlpr Can you check the failed tests here. Thanks. |
Contributor
Author
|
Same as #327 (comment). |
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Comment on lines
+31
to
+32
| resourceName := "cloudstack_security_group.security-group-resource" | ||
| dataSourceName := "data.cloudstack_security_group.security-group-data-source" |
Comment on lines
+53
to
+64
| resource "cloudstack_security_group" "security-group-resource" { | ||
| name = "%[1]s" | ||
| description = "Security group data source acceptance test" | ||
| } | ||
|
|
||
| data "cloudstack_security_group" "security-group-data-source" { | ||
| filter { | ||
| name = "name" | ||
| value = "^%[1]s$" | ||
| } | ||
| depends_on = [cloudstack_security_group.security-group-resource] | ||
| } |
Comment on lines
+123
to
+128
| for _, filter := range filters.List() { | ||
| values := filter.(map[string]interface{}) | ||
| pattern, err := regexp.Compile(values["value"].(string)) | ||
| if err != nil { | ||
| return false, fmt.Errorf("invalid regex: %s", err) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only handles the groups themselves, no rules yet. Even if this functionality gets added, It'd be better to keep them separate. Same filter function applied as other datasources do. Minimal amount of attributes but this is primarily to fetch IDs from separate states.