Skip to content

config cleanup - #13884

Open
DaanHoogland wants to merge 49 commits into
mainfrom
ghi10752-configCleanup
Open

config cleanup#13884
DaanHoogland wants to merge 49 commits into
mainfrom
ghi10752-configCleanup

Merge branch 'main' into ghi10752-configCleanup

7f55790
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Sep 2, 2026 in 9m 5s

Quality Gate failed

Failed conditions
26.3% Coverage on New Code (required ≥ 40%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1235 in server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAKNgPi3ej0ChNocDo0&open=AaAKNgPi3ej0ChNocDo0&pullRequest=13884

Check failure on line 181 in server/src/main/java/com/cloud/configuration/Config.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMVMSH6sOtJrG0c_h&open=AaAHMVMSH6sOtJrG0c_h&pullRequest=13884

Check failure on line 382 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename field "volumeStatsInterval" to prevent any misunderstanding/clash with field "VolumeStatsInterval". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMU2cH6sOtJrG0c_e&open=AaAHMU2cH6sOtJrG0c_e&pullRequest=13884

Check warning on line 149 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_publicIPCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SH&open=AaAFdWG4qJXQQ7HDE9SH&pullRequest=13884

Check warning on line 1419 in server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a primitive boolean expression here. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaALOSr01r5TurFMiqzi&open=AaALOSr01r5TurFMiqzi&pullRequest=13884

Check failure on line 34 in engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanningManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMT7KH6sOtJrG0c_W&open=AaAHMT7KH6sOtJrG0c_W&pullRequest=13884

Check failure on line 52 in api/src/main/java/com/cloud/deploy/DeploymentClusterPlanner.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 6 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMT-LH6sOtJrG0c_X&open=AaAHMT-LH6sOtJrG0c_X&pullRequest=13884

Check warning on line 1429 in server/src/test/java/com/cloud/configuration/ConfigurationManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquo6RdE24u2TNGQS&open=AaAHquo6RdE24u2TNGQS&pullRequest=13884

Check warning on line 48 in server/src/test/java/com/cloud/resource/DiscovererBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2ubGw8sSOR9q8QX&open=AaAPZ2ubGw8sSOR9q8QX&pullRequest=13884

Check failure on line 379 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename field "hostStatsInterval" to prevent any misunderstanding/clash with field "HostStatsInterval". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMU2cH6sOtJrG0c_c&open=AaAHMU2cH6sOtJrG0c_c&pullRequest=13884

Check failure on line 94 in api/src/main/java/com/cloud/network/NetworkModel.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Advanced" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMT_5H6sOtJrG0c_Y&open=AaAHMT_5H6sOtJrG0c_Y&pullRequest=13884

Check failure on line 63 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Specify the private bridge on host for private network" 5 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWBdqJXQQ7HDE9SA&open=AaAFdWBdqJXQQ7HDE9SA&pullRequest=13884

Check warning on line 887 in server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAGbHxQTV2yRQvmzXM3&open=AaAGbHxQTV2yRQvmzXM3&pullRequest=13884

Check warning on line 152 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_vlanCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SJ&open=AaAFdWG4qJXQQ7HDE9SJ&pullRequest=13884

Check warning on line 150 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_privateIPCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SG&open=AaAFdWG4qJXQQ7HDE9SG&pullRequest=13884

Check failure on line 45 in server/src/main/java/com/cloud/server/ManagementServer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 6 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquINRdE24u2TNGQO&open=AaAHquINRdE24u2TNGQO&pullRequest=13884

Check failure on line 82 in server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "false" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdV8EqJXQQ7HDE9R-&open=AaAFdV8EqJXQQ7HDE9R-&pullRequest=13884

Check warning on line 43 in server/src/test/java/com/cloud/resource/DiscovererBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "mock". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2ubGw8sSOR9q8QS&open=AaAPZ2ubGw8sSOR9q8QS&pullRequest=13884

Check failure on line 38 in engine/components-api/src/main/java/com/cloud/network/security/SecurityGroupManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Network" 4 times. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdVstqJXQQ7HDE9R2&open=AaAFdVstqJXQQ7HDE9R2&pullRequest=13884

Check failure on line 381 in server/src/main/java/com/cloud/server/StatsCollector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename field "storageStatsInterval" to prevent any misunderstanding/clash with field "StorageStatsInterval". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWDyqJXQQ7HDE9SC&open=AaAFdWDyqJXQQ7HDE9SC&pullRequest=13884

Check warning on line 45 in server/src/test/java/com/cloud/resource/DiscovererBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2ubGw8sSOR9q8QU&open=AaAPZ2ubGw8sSOR9q8QU&pullRequest=13884

Check warning on line 120 in server/src/main/java/com/cloud/network/ExternalFirewallDeviceManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Split this “Monster Class” into smaller and more specialized ones to reduce its dependencies on other classes from 31 to the maximum authorized 20 or less. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquAoRdE24u2TNGQL&open=AaAHquAoRdE24u2TNGQL&pullRequest=13884

Check warning on line 47 in server/src/test/java/com/cloud/resource/DiscovererBaseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAPZ2ubGw8sSOR9q8QW&open=AaAPZ2ubGw8sSOR9q8QW&pullRequest=13884

Check failure on line 893 in server/src/main/java/com/cloud/network/NetworkServiceImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHMUnuH6sOtJrG0c_a&open=AaAHMUnuH6sOtJrG0c_a&pullRequest=13884

Check warning on line 151 in server/src/main/java/com/cloud/alert/AlertManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "_secondaryStorageCapacityThreshold" field and declare it as a local variable in the relevant methods. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAFdWG4qJXQQ7HDE9SI&open=AaAFdWG4qJXQQ7HDE9SI&pullRequest=13884
View more details on SonarQubeCloud