Skip to content

allow update of ldap linked account - #13949

Open
DaanHoogland wants to merge 2 commits into
mainfrom
ghi11185-update-ldap-domain-on-account
Open

allow update of ldap linked account#13949
DaanHoogland wants to merge 2 commits into
mainfrom
ghi11185-update-ldap-domain-on-account

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #11185

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.74%. Comparing base (158fe4f) to head (012307c).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #13949   +/-   ##
=========================================
  Coverage     19.74%   19.74%           
- Complexity    19960    19976   +16     
=========================================
  Files          6371     6371           
  Lines        575784   575792    +8     
  Branches      70478    70479    +1     
=========================================
+ Hits         113665   113710   +45     
+ Misses       449765   449730   -35     
+ Partials      12354    12352    -2     
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 21.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.62%
Branch coverage 18.82%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@DaanHoogland
DaanHoogland force-pushed the ghi11185-update-ldap-domain-on-account branch from 4825b6d to cc543f0 Compare August 22, 2026 21:29
@DaanHoogland
DaanHoogland force-pushed the ghi11185-update-ldap-domain-on-account branch from 4ca51b7 to 012307c Compare August 25, 2026 19:13
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18984

@sonarqubecloud

Copy link
Copy Markdown

@DaanHoogland
DaanHoogland requested a review from shwstppr August 26, 2026 11:35
@DaanHoogland DaanHoogland added this to the 24.0.0 milestone Aug 26, 2026
@DaanHoogland
DaanHoogland requested a review from RosiKyu August 26, 2026 11:35
@DaanHoogland DaanHoogland moved this from Backlog to Ready in CloudStack Testing Sep 1, 2026
@DaanHoogland

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16859)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56436 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13949-t16859-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

Link Account to LDAP Improvement - Update ldapdomain value

2 participants