feat(dataframe): improve DataFrame::from_columns input types (#24630) - #24633
Open
cj-zhukov wants to merge 2 commits into
Open
feat(dataframe): improve DataFrame::from_columns input types (#24630)#24633cj-zhukov wants to merge 2 commits into
cj-zhukov wants to merge 2 commits into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24633 +/- ##
==========================================
- Coverage 81.43% 81.43% -0.01%
==========================================
Files 1118 1118
Lines 399414 399418 +4
Branches 399414 399418 +4
==========================================
- Hits 325278 325272 -6
- Misses 55145 55149 +4
- Partials 18991 18997 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Improve the
DataFrame::from_columnsAPI and give users more flexibility when constructing aDataFramefrom columns.What changes are included in this PR?
DataFrame::from_columnsto accept botharraysandVecsof columns.Are these changes tested?
Yes. Tests cover both
arrayandVecinputs and verify the resulting schema, data types, row count, and values.Are there any user-facing changes?
Yes. This is a non-breaking API improvement. Existing usage continues to work, while users can now choose between an
arrayand aVecwhen passing columns toDataFrame::from_columns.