fix(core): reject a DELETE or an UPDATE whose WHERE clause cannot reach the provider

[michaelsembwever]

Which issue does this PR close?

#24656

Rationale for this change

See ticket.

What changes are included in this PR?

A DELETE or an UPDATE whose WHERE clause holds an IN or an EXISTS subquery changed every row of the target table, and reported the whole table as affected. The optimizer rewrites the subquery into a semi join, so the condition leaves the Filter nodes that extract_dml_filters() reads. The provider then received an empty filter list, which is the encoding for "no WHERE clause", and applied the statement to all rows.

An always-false WHERE clause reached the provider the same way. The simplifier folds the predicate into an empty relation, so again no filter survived, and a DELETE FROM t WHERE false emptied the table.

Add classify_dml_input(), which walks the input plan of a DELETE or an UPDATE before the provider hook runs:

• an empty relation means that no row matches, so the statement reports a count of 0 and the hook is not called;
• a join, a predicate on another table, or any other node that restricts or multiplies rows raises a "not implemented" error, and the hook is not called.

The hook stays untouched in every rejected case, so a provider that writes to durable storage cannot lose rows.

Are these changes tested?

Only with the tests provided in this patch, which are based on the assumptions made in the ticket description.

Are there any user-facing changes?

?

[codecov-commenter]

Codecov Report

❌ Patch coverage is 76.47059% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.44%. Comparing base (a6e2d3f) to head (5f3e301).
⚠️ Report is 36 commits behind head on main.

Files with missing lines	Patch %	Lines
datafusion/core/src/physical_planner.rs	76.47%	7 Missing and 9 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #24657      +/-   ##
==========================================
+ Coverage   81.36%   81.44%   +0.07%     
==========================================
  Files        1117     1118       +1     
  Lines      397872   399611    +1739     
  Branches   397872   399611    +1739     
==========================================
+ Hits       323725   325451    +1726     
+ Misses      55229    55153      -76     
- Partials    18918    19007      +89     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.