fix(proto): preserve AnalyzeExec metric types across serialization - #24669
Open
haohuaijin wants to merge 2 commits into
Open
fix(proto): preserve AnalyzeExec metric types across serialization#24669haohuaijin wants to merge 2 commits into
haohuaijin wants to merge 2 commits into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24669 +/- ##
==========================================
+ Coverage 81.44% 81.48% +0.04%
==========================================
Files 1118 1118
Lines 399550 399661 +111
Branches 399550 399661 +111
==========================================
+ Hits 325398 325675 +277
+ Misses 55154 54915 -239
- Partials 18998 19071 +73 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
AnalyzeExec::metric_typeswas lost during protobuf round-trips, causing non-default selections such as summary-only metrics to reset to[Summary, Dev].What changes are included in this PR?
AnalyzeExec::metric_types.Are these changes tested?
Yes.
datafusion-protointegration testsAre there any user-facing changes?
Yes.
EXPLAIN ANALYZEmetric type selections now survive physical-plan protobuf serialization. There are no public Rust API changes.