refactor(proto): destructure CASE and IN-list expression serde hooks - #24700
Open
buraksenn wants to merge 1 commit into
Open
refactor(proto): destructure CASE and IN-list expression serde hooks#24700buraksenn wants to merge 1 commit into
buraksenn wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24700 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 1119 1119
Lines 400411 400428 +17
Branches 400411 400428 +17
==========================================
+ Hits 326144 326149 +5
- Misses 55195 55202 +7
- Partials 19072 19077 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Proto hooks that access fields individually can silently omit newly added state. Exhaustive destructuring makes such omissions compile errors.
What changes are included in this PR?
CaseExpr,CaseBody, andInListExprin their encoders.eval_methodandstatic_filteras constructor-derived state.The behavior and wire format are unchanged.
Are these changes tested?
Covered by the existing CASE and IN-list proto hook tests:
Are there any user-facing changes?
No.