fix ut

apache · Sep 26, 2024 · 19d9cce · 19d9cce
1 parent c99203a
commit 19d9cce
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/...n/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java b/...n/java/org/apache/dolphinscheduler/api/permission/ResourcePermissionCheckServiceImpl.java
@@ -260,10 +260,7 @@ public boolean permissionCheck(int userId, String url, Logger logger) {
                 logger.error("User does not exist, userId:{}.", userId);
                 return false;
             }
-            if (user.getUserType() != UserType.ADMIN_USER) {
-                return false;
-            }
-            return true;
+            return user.getUserType() == UserType.ADMIN_USER;
         }
 
         @Override

diff --git a/...va/org/apache/dolphinscheduler/api/permission/EnvironmentResourcePermissionCheckTest.java b/...va/org/apache/dolphinscheduler/api/permission/EnvironmentResourcePermissionCheckTest.java
@@ -60,6 +60,12 @@ public void testPermissionCheck() {
         when(userDao.queryById(user.getId())).thenReturn(user);
         Assertions.assertTrue(environmentResourcePermissionCheck.permissionCheck(user.getId(), null, logger));
     }
+    @Test
+    public void testPermissionCheckFail() {
+        User user = getLoginAdminUser();
+        when(userDao.queryById(user.getId())).thenReturn(null);
+        Assertions.assertFalse(environmentResourcePermissionCheck.permissionCheck(user.getId(), null, logger));
+    }
 
     @Test
     public void testAuthorizationTypes() {