[DSIP-27][Task Plugin] Some improvements of JAVA task plugin #16542
Conversation
ailiujiarui
requested review from
songjianet,
Amy0104,
caishunfeng,
SbloodyS,
zhuangchong and
Gallardot
as code owners
SbloodyS
changed the title
SbloodyS
added
first time contributor
SbloodyS
changed the title
ailiujiarui
force-pushed
the
dev
branch
2 times, most recently
from
9c45ca0
to
6d16b63
Compare
ailiujiarui
force-pushed
the
dev
branch
3 times, most recently
from
37b92ed
to
151bdfe
Compare
Please check if additional explanation is needed
|
...ler-task-java/src/main/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java
Show resolved
Hide resolved
ailiujiarui
force-pushed
the
dev
branch
3 times, most recently
from
e84bc5f
to
f1eda5f
Compare
|
Hi everyone, could you please let me know if there’s anything that needs improvement? Thanks! |
SbloodyS
changed the title
SbloodyS
changed the title
"'computed' is defined but never used"
| - name: WorkflowJavaTaskE2ETest | ||
| class: org.apache.dolphinscheduler.e2e.cases.WorkflowJavaTaskE2ETest |
There was a problem hiding this comment.
Why delete this? CI-related content should not be deleted in PR in general.
There was a problem hiding this comment.
Since the original workflowJavaTaskE2ETest was used to test Java code types under Java task types, and this feature has been removed, this test is no longer needed.
There was a problem hiding this comment.
You should modify it base on the new logic according to the previous test case, not delete it.
|
I am not sure what caused the bc38b84 CI test error |
Conflict has been resolved. |
|
I didn't see any docs in this PR. Please check it. |
Purpose of the pull request
Update the Java task plugin
close:#15819
Brief change log
Only the displayed name has been modified, the functionality remains unchanged.
Allow users to upload normal type of jar files, which require external libraries to run properly. Users do not need to package all libraries and runtime files into a fat jar each time, making the submission of jar files more flexible and convenient.
Delete tests about JAVA type and add the test of NORMAL JAR type
Since the original workflowJavaTaskE2ETest was used to test Java code types under Java task types, and this feature has been removed, this test is no longer needed.
type of FATJAR
type of NORMALJAR
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md