[Fix-16668][api-server] Fix SSO login bug #16669
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when use sso login type, refresh login page and click sso login button, will dialog a error tips: State or code entered incorrectly.
SbloodyS
added
bug
Gallardot
reviewed
Sep 27, 2024
| @@ -158,7 +158,8 @@ public Result ssoLogin(HttpServletRequest request) { | |||
| if (session.getAttribute(Constants.SSO_LOGIN_USER_STATE) == null) { | |||
| session.setAttribute(Constants.SSO_LOGIN_USER_STATE, randomState); | |||
| } | |||
| return Result.success(((AbstractSsoAuthenticator) authenticator).getSignInUrl(randomState)); | |||
| return Result.success(((AbstractSsoAuthenticator) authenticator) | |||
| .getSignInUrl(session.getAttribute(Constants.SSO_LOGIN_USER_STATE).toString())); | |||
There was a problem hiding this comment.
LGTM. Let's make it better.
HttpSession session = request.getSession();
if (session.getAttribute(Constants.SSO_LOGIN_USER_STATE) == null) {
String randomState = UUID.randomUUID().toString();
session.setAttribute(Constants.SSO_LOGIN_USER_STATE, randomState);
}
return Result.success(((AbstractSsoAuthenticator) authenticator)
.getSignInUrl(session.getAttribute(Constants.SSO_LOGIN_USER_STATE).toString()));
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
By the way, do not close the related issue when the pr is open. The issue will be automatically closed when the pr is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #16668
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md