Skip to content

[refactor](lance) Group Lance scan parameters in Thrift - #67110

Merged
yiguolei merged 2 commits into
apache:branch-4.1from
zhangstar333:branch-41-thrift
Aug 26, 2026
Merged

[refactor](lance) Group Lance scan parameters in Thrift#67110
yiguolei merged 2 commits into
apache:branch-4.1from
zhangstar333:branch-41-thrift

Conversation

@zhangstar333

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Problem Summary:
Group Lance-specific scan-node parameters into TLanceScanParams and update the FE/BE access paths.
Keep TFileScanRangeParams clean and make Lance scan parameters easier to extend.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zhangstar333
zhangstar333 requested a review from yiguolei as a code owner August 25, 2026 04:36
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.24% (1911/2474)
Line Coverage 64.32% (34165/53120)
Region Coverage 51.88% (32721/63071)
Branch Coverage 54.17% (9988/18438)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/12) 🎉
Increment coverage report
Complete coverage report

@zhangstar333

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.24% (1911/2474)
Line Coverage 64.33% (34170/53120)
Region Coverage 51.87% (32716/63071)
Branch Coverage 54.15% (9985/18438)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (28/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.32% (25593/43146)
Line Coverage 43.82% (261480/596684)
Region Coverage 39.77% (207108/520813)
Branch Coverage 41.27% (95566/231576)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (28/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.07% (31138/42038)
Line Coverage 58.28% (345141/592191)
Region Coverage 54.98% (287050/522091)
Branch Coverage 55.93% (129375/231310)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 83.33% (10/12) 🎉
Increment coverage report
Complete coverage report

@yiguolei
yiguolei merged commit ce5f5dd into apache:branch-4.1 Aug 26, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants