branch-4.1: [fix](cache) fix NPE when a partition of olap table has been dropped #65889 - #67124
Merged
Merged
Conversation
…65889) Issue Number: close #65886 Problem Summary: `CacheAnalyzer.buildCacheTableForOlapScanNode` iterates over the `selectedPartitionIds` of an `OlapScanNode` and calls `olapTable.getPartition(partitionId)` for each id. If a partition is dropped between query planning and cache building (e.g. a concurrent `DROP PARTITION`), `getPartition` returns `null`, and the subsequent `partition.getVisibleVersionTime()` throws a `NullPointerException`, aborting the cache update for the query. Root cause: the loop had no null-check on the partition returned by `getPartition`. Fix: skip partitions that are already null (`if (partition == null) continue;`). A dropped partition can no longer contribute to the cache, so it is skipped and the remaining partitions are still processed. The end-to-end effect is that the SQL cache update no longer crashes when a partition races with the cache build; the cache is built from the still-existing partitions instead.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Aug 26, 2026
Contributor
Author
|
PR approved by anyone and no changes requested. |
github-actions
Bot
added
the
approved
Contributor
Author
|
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65889