Skip to content

branch-4.1: [fix](cloud) Decrement delete bitmap packed file ref counts when recycling tablets #66919 - #67127

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66919-branch-4.1
Aug 26, 2026
Merged

branch-4.1: [fix](cloud) Decrement delete bitmap packed file ref counts when recycling tablets #66919#67127
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66919-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #66919

…cling tablets (#66919)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
When recycling a dropped tablet, recycle_tablet decremented packed file
reference counts for rowset data but omitted packed delete bitmap files.
As a result, delete bitmap packed file metadata and objects could remain
after all referenced rowsets had been recycled.

Call decrement_delete_bitmap_packed_file_ref_counts for both regular
rowsets and restore-job rowsets before deleting the tablet metadata.

Add a unit test that constructs a blob-backed delete bitmap referencing
a packed file. The test failed before the fix because the packed file KV
and object remained, and passes after the fix.
@github-actions
github-actions Bot requested a review from yiguolei as a code owner August 25, 2026 10:10
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 12.50% (2/16) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.24% (1911/2474)
Line Coverage 64.37% (34205/53136)
Region Coverage 51.83% (32700/63089)
Branch Coverage 54.21% (9998/18442)

@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

@yiguolei
yiguolei merged commit 25601ad into branch-4.1 Aug 26, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants