branch-4.1: [fix](user variable) Preserve TIMESTAMPTZ user variable type #66833 - #67128
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](user variable) Preserve TIMESTAMPTZ user variable type #66833#67128github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
TIMESTAMPTZ user variables could lose their original type when converted from a legacy literal to a Nereids literal. The value was restored as a string, which changed timezone rendering and comparison semantics after the session timezone changed. Root cause: `ConnectContext.getLiteralForUserVar` did not handle `DateLiteral` and fell back to string conversion. This change uses the existing legacy literal conversion path to preserve the TIMESTAMPTZ type, scale, and instant value.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #66833