Upgrade Groovy to 5.1.1 - #16235
Conversation
Bumps the framework's groovy.version pin (both the primary BOM and the grails-micronaut-bom/grails-hibernate5-micronaut-bom literal) from 5.1.0 to 5.1.1, which fixes a Metaspace leak on parallel Tomcat deployments (GROOVY-12142), a static type checking regression causing ClassCastException on instanceof-narrowed fields (GROOVY-12166), and a Groovy 4/5 @immutable bytecode incompatibility (GROOVY-12257). Also corrects stale "5.0.x" references in CLAUDE.md/AGENTS.md and the groovy/gradle/grails developer skill docs that had drifted from the prior 5.1.0 bump.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #16235 +/- ##
==================================================
- Coverage 54.1488% 54.1330% -0.0158%
+ Complexity 20258 20254 -4
==================================================
Files 2098 2098
Lines 100920 100920
Branches 17898 17898
==================================================
- Hits 54647 54631 -16
- Misses 38484 38502 +18
+ Partials 7789 7787 -2 🚀 New features to boost your workflow:
|
🚨 TestLens detected 1 failed test 🚨Here is what you can do:
Test SummaryCI / Build Grails-Core (Windows JDK 25 shard 0) > :grails-wrapper:test
🏷️ Commit: 4b3a340 Test FailuresGrailsUpdaterSpec > remote wrapper rejects HTTP redirect responses (:grails-wrapper:test in CI / Build Grails-Core (Windows JDK 25 shard 0))Rerun ControlsSelect tests to mute in this pull request:
Reuse successful test results:
Click the checkbox to trigger a rerun:
Learn more about TestLens at testlens.app/docs. |
|
I cannot merge this as long as there is an OutOfMemory Exception being thrown. On slack @paulk-asert mentioned: We have had another user report increased memory requirements for 5.1.1 over 5.1.0, the suggestion for them while we try to find a better fix is to bump up their mem spec to You could also potentially test against: And @jamesfredley has created a potential fix for it here #16167 So perhaps 5.1.1 is not suitable as it is? @matrei / @jdaugherty since you approved this, what are your thoughts? |
@sbglasius I think we hold off 5.1.1 until there is a fix for the memory problem. |
|
I have changed this PR to draft for the time being, until the issue with Groovy 5.1.1 is resolved. |
Summary
groovy.versionfrom5.1.0to5.1.1independencies.gradle(both the primary BOM pin and the duplicate literal used bygrails-micronaut-bom/grails-hibernate5-micronaut-bom)AGENTS.md/CLAUDE.mdand thegroovy-developer,gradle-developer, andgrails-developerskill docs, which had drifted from the prior 5.1.0 bumpGroovy 5.1.1 is a maintenance release on the 5.1.x line, fixing:
ClassCastExceptiononinstanceof-narrowed fields@Immutablebytecode incompatibilitySee the changelog.
Test plan
./gradlew clean build -PskipTestssucceeds./gradlew validateDependencyVersions— one pre-existing, unrelated failure (org.graalvm.sdk:nativeimageversion drift in the micronaut example projects) confirmed to also occur on unmodified 5.1.0, so not introduced by this change