Remove dead xml-apis dependency exclusions - #16279
Open
codeconsole wants to merge 1 commit into
Open
Conversation
xml-apis:xml-apis has not been reachable from any of these dependencies for several major versions, so the exclusions are no-ops: - hibernate-core 7.4.1.Final and hibernate-core-jakarta 5.6.15.Final never declare xml-apis. Hibernate's own POM already excludes it from every one of its dependencies, and mapping XML has been bound with JAXB (jakarta.xml.bind-api + jaxb-runtime) since Hibernate 6 dropped dom4j. - commons-validator 1.9.0 no longer pulls commons-digester/xml-apis. The resolved compileClasspath, runtimeClasspath and testRuntimeClasspath of all three modules are byte-identical with the exclusions removed. The only publication change is the removal of three dead <exclusion> entries from the generated POMs.
✅ All tests passed ✅Test SummaryCI / Functional Tests (Java 25, indy=false, shard 1) > :grails-test-examples-gsp-sitemesh3:integrationTest
🏷️ Commit: e469c27 Learn more about TestLens at testlens.app/docs. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #16279 +/- ##
==================================================
- Coverage 54.7149% 54.7139% -0.0010%
Complexity 20421 20421
==================================================
Files 2101 2101
Lines 100978 100978
Branches 17907 17907
==================================================
- Hits 55250 55249 -1
Misses 37860 37860
- Partials 7868 7869 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xml-apis:xml-apishas not been reachable from any of these dependencies for several major versions, so the four exclusions are no-ops:hibernate-core7.4.1.Final andhibernate-core-jakarta5.6.15.Final never declarexml-apis. Hibernate's own POM already excludes it from every one of its dependencies, and mapping XML has been bound with JAXB (jakarta.xml.bind-api+jaxb-runtime) since Hibernate 6 dropped dom4j.commons-validator1.9.0 no longer pullscommons-digester/xml-apis.Verification
With the exclusions removed,
dependencyInsight --dependency xml-apisfinds no match oncompileClasspath,runtimeClasspath, ortestRuntimeClasspathfor any of the three modules, and the full resolved dependency graphs are byte-identical to before.The only publication change is the removal of three dead
<exclusion>entries from the generated POMs (the fourth is on acompileOnlydependency, which is not published).:grails-datamapping-validation:test,:grails-data-hibernate7-core:testand:grails-data-hibernate5-core:testpass (3066 tests, 0 failures), andaggregateStyleViolationsreports no Checkstyle or CodeNarc violations.