fix(ci): modernize Codecov uploads - #3169
Open
contrueCT wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
============================================
+ Coverage 41.06% 46.35% +5.28%
- Complexity 519 706 +187
============================================
Files 771 791 +20
Lines 65962 67379 +1417
Branches 8766 8985 +219
============================================
+ Hits 27088 31233 +4145
+ Misses 36008 32945 -3063
- Partials 2866 3201 +335 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
HugeGraph still uses
codecov/codecov-action@v3for Commons,PD/Store/HStore, and Server coverage uploads. Fork pull requests cannot access
CODECOV_TOKEN, so v3 falls back to the legacy anonymous uploader. Thatuploader shares a global rate limit: HTTP 429 failures were observed on #3167
and #3161, while the uploader still exited with status 0 and left Codecov with
only a subset of the expected reports.
This PR modernizes the upload boundary only. It does not change JaCoCo
collection, aggregation, coverage thresholds, or production code. The
PD/Store report aggregation work remains independent in #3160 and #3161.
Main Changes
codecov/codecov-action@v3to@v5.CODECOV_TOKENfor trusted push and same-repository runs.On fork pull requests the secret remains unavailable by design, and v5 uses
its fork-aware tokenless upload path.
fileinput withfilesin every upload step.actions, missing
filesinputs, missing trusted-run token inputs, removedexpected uploads, and newly added legacy upload steps.
add
fail_ci_if_error: true.Verifying these changes
bash hugegraph-server/hugegraph-dist/src/assembly/travis/test-codecov-upload-config.shmvn -q apache-rat:check -N -ntpmvn editorconfig:check -pl hugegraph-server/hugegraph-dist -am -ntpgit diff --checkafter all five upload steps were migrated.
added workflow and does not mistake
env.tokenforwith.token.The external upload result is intentionally left to this PR's GitHub Actions
run, which exercises the v5 fork-aware tokenless path that cannot be reproduced
as a local Codecov upload.
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need