Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate plugin to Taverna 3 #4

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Migrate plugin to Taverna 3 #4

wants to merge 14 commits into from

Conversation

edikaradumi
Copy link
Contributor

  • Updated 52North library to latest version with Apache license
  • Created GisClient interface and implementation
  • Added GisClientFactory
  • Implement GisActivityFactory
  • Improve GisActivity configuration

@edikaradumi
Remove wps_config.xml as it is not used
9e65fc9
@edikaradumi
add taverna-git-client template
8d4a3da
@edikaradumi
implemented gis-client inteface and corresponding JUnit tests
96aea11
@edikaradumi
Update 52n-wps-client-lib
e957dd1
@edikaradumi
format pom code
dddc272
@edikaradumi
Add GisClientFactory for creating the required GisClient Implementation
84613b9 
The user should use the GisClientFactory to get the right GisClient parser. Different GisClients that use different libraries might be implemented.
@edikaradumi
Update Gis client interface and implementation
5d022d2
@edikaradumi
Add Configuration Bean annotations
dc01eff
@edikaradumi
Update ServiceDescription ACTIVITY_TYPE
f199915
@edikaradumi
Implement GisActivityFactory
a33f3cc
@edikaradumi
Update GisActivity to use Jackson object instead of ConfigBean
99d32a7
@edikaradumi
Remove port parsing in GisServiceProvider
223c292
@edikaradumi
Fix GisActivityFactory tests
d34cd58
@edikaradumi
example config
ee17940
@stain
Copy link
Member

stain commented Dec 6, 2017

@edikaradumi, what could be missing? We got build errors..

(Thanks @redmitry for testing!)

COMPILATION ERROR :
-------------------------------------------------------------
org/apache/taverna/gis/GisActivityHealthChecker.java:[57,60]
incompatible types: org.apache.taverna.gis.GisActivityConfigurationBean
cannot be converted to com.fasterxml.jackson.databind.JsonNode
org/apache/taverna/gis/GisActivityFactory.java:[52,46] cannot find symbol
   symbol:   variable ACTIVITY_TYPE
   location: class org.apache.taverna.gis.GisActivity
org/apache/taverna/gis/GisActivityFactory.java:[72,62] cannot find symbol
   symbol:   variable IN_FIRST_INPUT
   location: class org.apache.taverna.gis.GisActivityFactory
org/apache/taverna/gis/GisActivityFactory.java:[77,70] cannot find symbol
   symbol:   variable IN_EXTRA_DATA
   location: class org.apache.taverna.gis.GisActivityFactory
org/apache/taverna/gis/GisActivityFactory.java:[91,72] cannot find symbol
   symbol:   variable OUT_REPORT
   location: class org.apache.taverna.gis.GisActivityFactory
org/apache/taverna/gis/GisActivityFactory.java:[95,64] cannot find symbol
   symbol:   variable OUT_SIMPLE_OUTPUT
   location: class org.apache.taverna.gis.GisActivityFactory
org/apache/taverna/gis/GisActivityFactory.java:[97,64] cannot find symbol
   symbol:   variable OUT_MORE_OUTPUTS
   location: class org.apache.taverna.gis.GisActivityFactory
7 errors

@edikaradumi
Copy link
Contributor Author

Hi Stian,

I'll have a look later today. It has been a while since I worked on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edikaradumi @stain