-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Domain List refactoring #1820
Draft
chibenwa
wants to merge
18
commits into
apache:master
Choose a base branch
from
chibenwa:domain-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5137bd0 - Browse repository at this point
Copy the full SHA 5137bd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e1d6e6 - Browse repository at this point
Copy the full SHA 8e1d6e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e15caa6 - Browse repository at this point
Copy the full SHA e15caa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66f5141 - Browse repository at this point
Copy the full SHA 66f5141View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c1842 - Browse repository at this point
Copy the full SHA 15c1842View commit details -
Configuration menu - View commit details
-
Copy full SHA for e51a690 - Browse repository at this point
Copy the full SHA e51a690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c9c1fb - Browse repository at this point
Copy the full SHA 4c9c1fbView commit details -
Default domain should be read from DomainListConfiguration
Also its value is never null. Change DomainListConfiguration constructor visibility in order to ensure this.
Configuration menu - View commit details
-
Copy full SHA for dc9c4fd - Browse repository at this point
Copy the full SHA dc9c4fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c124fb2 - Browse repository at this point
Copy the full SHA c124fb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d274cb0 - Browse repository at this point
Copy the full SHA d274cb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc1bb7d - Browse repository at this point
Copy the full SHA fc1bb7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e8e13d - Browse repository at this point
Copy the full SHA 6e8e13dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 758fe41 - Browse repository at this point
Copy the full SHA 758fe41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42a761c - Browse repository at this point
Copy the full SHA 42a761cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 38ad1b3 - Browse repository at this point
Copy the full SHA 38ad1b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 773edb5 - Browse repository at this point
Copy the full SHA 773edb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2aeac6 - Browse repository at this point
Copy the full SHA b2aeac6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f39e909 - Browse repository at this point
Copy the full SHA f39e909View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.