Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After surefire 2058 #519

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

After surefire 2058 #519

wants to merge 2 commits into from

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Apr 13, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

countDecodedBytes += readInputBytes;
strings.add( ( (Buffer) output ).flip().toString() );
( (Buffer) output ).clear();
memento.getLine().setPositionByteBuffer( 0 );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason of resetting line position here?

Will give this branch a try later. Maybe compare events dump before and after on single test runs, and just see if larger projects have no other issues.

I think I already tried with removed do-while once, because it was suspicious at first look. But didn't want to change anything else in #518 , but my guess was that that wile condition is never true.

Copy link
Contributor Author

@Tibor17 Tibor17 Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zoltanmeze memento.getLine() holds the line which could not be properly decoded and it is eligible for printing a corruption status on the console.

Copy link
Contributor Author

@Tibor17 Tibor17 Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After properly decoded bytes, we clear the buffer and new bytes will be decoded. The corrupted line has to reset to 0 and remaining is 0 too of course.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MalformedFrameException is caught, whole byte sequence is printed as a corrupted string starting by memento.getLine().getPositionByteBuffer() up to the buffer's position.

Copy link
Contributor

@zoltanmeze zoltanmeze Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Wouldn't read( memento, bytesToRead ); also reset this to 0 in every iteration starting from second?

Copy link
Contributor Author

@Tibor17 Tibor17 Apr 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The memento holds the reference to the buffer too. And if I clean it up, I should reset the position variable via memento.getLine().setPositionByteBuffer( 0 ) in order to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants