Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive AuthzTest coverage of all grant and revoke operations #364

Merged

Conversation

dennishuo
Copy link
Contributor

@dennishuo dennishuo commented Oct 10, 2024

Description

Add comprehensive AuthzTest coverage of all grant and revoke operations

Fix consistency of ASSIGN_PRINCIPAL_ROLE in line with #361

Test cases for:
assignPrincipalRoleToPrincipal
revokePrincipalRoleFromPrincipal
assignCatalogRoleToPrincipalRole
revokeCatalogRoleFromPrincipalRole
grantPrivilegeOnRootContainerToPrincipalRole
revokePrivilegeOnRootContainerFromPrincipalRole
grantPrivilegeOnCatalogToRole
revokePrivilegeOnCatalogFromRole
grantPrivilegeOnNamespaceToRole
revokePrivilegeOnNamespaceFromRole
grantPrivilegeOnTableToRole
revokePrivilegeOnTableFromRole
grantPrivilegeOnViewToRole
revokePrivilegeOnViewFromRole

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Adds tests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • PolarisAdminServiceAuthzTest

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Fix consistency of ASSIGN_PRINCIPAL_ROLE in line with apache#361

Test cases for:
assignPrincipalRoleToPrincipal
revokePrincipalRoleFromPrincipal
assignCatalogRoleToPrincipalRole
revokeCatalogRoleFromPrincipalRole
grantPrivilegeOnRootContainerToPrincipalRole
revokePrivilegeOnRootContainerFromPrincipalRole
grantPrivilegeOnCatalogToRole
revokePrivilegeOnCatalogFromRole
grantPrivilegeOnNamespaceToRole
revokePrivilegeOnNamespaceFromRole
grantPrivilegeOnTableToRole
revokePrivilegeOnTableFromRole
grantPrivilegeOnViewToRole
revokePrivilegeOnViewFromRole
@eric-maynard eric-maynard enabled auto-merge (squash) October 14, 2024 23:02
@eric-maynard eric-maynard merged commit 1414305 into apache:main Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants