Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible the HTTP header properties with PIP-279 #1299

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Oct 23, 2024

Motivation

After pip-279, all properties keys and values use json string save to header: X-Pulsar-Property

This PR to compatible with this change when using subscription admin API.

Also, Using pip-279 also avoids the issue where the Go HTTP client automatically formats HTTP headers: golang/go#37834, This will impact the peek command, the previous method might retrieve properties with inconsistent casing compared to the user-defined.

Modifications

  • Compatible the HTTP header properties with PIP-279

Verifying this change

  • Add TestPeekMessageWithProperties to cover this.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@shibd shibd self-assigned this Oct 23, 2024
@BewareMyPower BewareMyPower changed the title Compatible the HTTP header properties with SNIP-279 Compatible the HTTP header properties with PIP-279 Oct 24, 2024
@RobertIndie RobertIndie merged commit a7ef9ed into apache:master Oct 24, 2024
7 checks passed
@BewareMyPower BewareMyPower added this to the v0.15.0 milestone Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants