-
Notifications
You must be signed in to change notification settings - Fork 970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RANGER-4418: Upgrade hadoop version and use shaded hadoop client artifacts #282
base: master
Are you sure you want to change the base?
Conversation
82727a0
to
a253fb3
Compare
@eubnara Can you rebase your PR? |
e8d3ac0
to
1f876d3
Compare
3ff1c0a
to
e8a24d5
Compare
related to RANGER-4858
<artifactId>jsr305</artifactId> | ||
<version>${jsr305.version}</version> | ||
<scope>compile</scope> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for import javax.annotation.concurrent.ThreadSafe;
in AmazonCloudWatchAuditDestination.java
.
<groupId>commons-collections</groupId> | ||
<artifactId>commons-collections</artifactId> | ||
<version>${commons.collections.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project ranger-plugins-audit: Compilation failure: Compilation failure:
[ERROR] /home/eub/github/eubnara-ranger/agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java:[21,37] error: package org.apache.commons.collections does not exist
[ERROR] /home/eub/github/eubnara-ranger/agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java:[175,31] error: cannot find symbol
<groupId>javax.servlet</groupId> | ||
<artifactId>javax.servlet-api</artifactId> | ||
<version>${javax.servlet.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RangerAdminRESTClient
needs import javax.servlet.http.HttpServletResponse;
.
<dependency> | ||
<groupId>com.google.code.gson</groupId> | ||
<artifactId>gson</artifactId> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbstractRangerAdminClient.java
needs
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
dd4887e
to
2777445
Compare
<groupId>com.sun.xml.bind</groupId> | ||
<artifactId>jaxb-impl</artifactId> | ||
<version>${jaxb-impl.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import com.sun.istack.NotNull;
in RangerCache.java needs jaxb-impl.
<groupId>org.apache.httpcomponents</groupId> | ||
<artifactId>httpclient</artifactId> | ||
<version>${httpcomponents.httpclient.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CredentialsProviderUtil.java
and KerberosCredentialsProvider.java
need it.
<exclusion> | ||
<groupId>javax.ws.rs</groupId> | ||
<artifactId>jsr311-api</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid conflicts in RangerAdminJersey2RestClient.java
, exclude it.
[INFO] +- org.glassfish.jersey.core:jersey-client:jar:2.35:compile
[INFO] | +- jakarta.ws.rs:jakarta.ws.rs-api:jar:2.1.6:compile
[INFO] | +- org.glassfish.jersey.core:jersey-common:jar:2.35:compile
[INFO] | | +- jakarta.annotation:jakarta.annotation-api:jar:1.3.5:compile
[INFO] | | \- org.glassfish.hk2:osgi-resource-locator:jar:1.0.3:compile
[INFO] | \- org.glassfish.hk2.external:jakarta.inject:jar:2.6.1:compile
javax.ws.rs.core.Response
on jakarta.ws.rs-api-2.1.6.jar
has readEntity()
.
javax.ws.rs.core.Response
on jsr311-api-1.1.1.jar
doesn't has readEntity()
.
dceeccf
to
44027ac
Compare
<exclusion> | ||
<groupId>ch.qos.reload4j</groupId> | ||
<artifactId>*</artifactId> | ||
</exclusion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid conflict log4j implementation for Ranger, exclude it. Ranger doesn't use ch.qos.reload4j.
@@ -18,7 +18,6 @@ | |||
*/ | |||
package org.apache.ranger.services.nifi.registry.client; | |||
|
|||
import com.google.common.io.Resources; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't have guava lib. Just read file using java lib.
<groupId>javax.servlet</groupId> | ||
<artifactId>javax.servlet-api</artifactId> | ||
<version>${javax.servlet.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RangerDefaultJwtAuthHandler.java, RangerAuthHandler.java need this lib.
<groupId>org.slf4j</groupId> | ||
<artifactId>log4j-over-slf4j</artifactId> | ||
<version>${slf4j.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RangerJwtAuthHandler.java needs it.
@bhavikpatel9977 |
d963cfe
to
54e20f2
Compare
commons-text already has commons-lang3
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. RANGER-XXXX: Fix a typo in YYY))
Please refer to https://issues.apache.org/jira/browse/RANGER-4418.
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Manually tested on private hadoop cluster.