-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][CONNECTORS-V2-Paimon] Piamon Sink supports changelog-procuder is lookup and full-compaction mode #7834
Open
hawk9821
wants to merge
3
commits into
apache:dev
Choose a base branch
from
hawk9821:paimon_change_producer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawk9821
force-pushed
the
paimon_change_producer
branch
from
October 14, 2024 11:39
9a053d0
to
4084633
Compare
cc @dailai |
hawk9821
force-pushed
the
paimon_change_producer
branch
2 times, most recently
from
October 16, 2024 08:17
9bf3fd5
to
dd69259
Compare
hawk9821
changed the title
[Feature][CONNECTORS-V2-Paimon] changelog-producer support the lookup and full-compaction mode
[Feature][CONNECTORS-V2-Paimon] Piamon Sink supports changelog-procuder is lookup and full-compaction mode
Oct 16, 2024
dailai
reviewed
Oct 17, 2024
dailai
reviewed
Oct 17, 2024
dailai
reviewed
Oct 17, 2024
...main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalogFactory.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Oct 17, 2024
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/config/PaimonSinkConfig.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Oct 17, 2024
dailai
reviewed
Oct 17, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Oct 17, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Oct 17, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Oct 17, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java
Outdated
Show resolved
Hide resolved
dailai
reviewed
Oct 17, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java
Show resolved
Hide resolved
hawk9821
force-pushed
the
paimon_change_producer
branch
2 times, most recently
from
October 17, 2024 13:26
6bd8322
to
91b055d
Compare
dailai
reviewed
Oct 18, 2024
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/sink/PaimonSinkWriter.java
Outdated
Show resolved
Hide resolved
dailai
previously approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please fix ci. |
hawk9821
force-pushed
the
paimon_change_producer
branch
from
October 18, 2024 01:58
3af0f38
to
5e4e266
Compare
dailai
previously approved these changes
Oct 18, 2024
Hisoka-X
reviewed
Oct 18, 2024
...ctor-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/CancelStreamJob.java
Outdated
Show resolved
Hide resolved
hailin0
previously approved these changes
Oct 18, 2024
…and full-compaction mode
hawk9821
force-pushed
the
paimon_change_producer
branch
from
October 18, 2024 13:26
b957002
to
e39701e
Compare
…and full-compaction mode
…and full-compaction mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Piamon Sink supports writing to the Piamon table whose changelog-procuder is lookup and full-compaction mode.
Does this PR introduce any user-facing change?
How was this patch tested?
e2e: PaimonSinkCDCIT#testChangelogLookup PaimonSinkCDCIT#testChangelogFullCompaction
Check list
New License Guide
release-note
.