Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-10894: Update streaming parser to properly handle nested quotes #1781

Conversation

magibney
Copy link
Contributor

See: SOLR-10894

Co-authored-by: Justin Sweeney <justinsweeney@fullstory.com>
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 13, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@HoustonPutman
Copy link
Contributor

Hey @magibney I have a change to make this just generic for any number of escapes of the quote. (for example if there was an escaped quote in a phrase query)

Mind if I push to your branch?

magibney and others added 3 commits August 2, 2023 09:43
Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but some documentation in the ref guide on how streaming expressions escaping happens would likely be useful!

Copy link

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution!

@github-actions github-actions bot added the stale PR not updated in 60 days label Feb 15, 2024
Copy link

github-actions bot commented Oct 7, 2024

This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.

@github-actions github-actions bot added the closed-stale Closed after being stale for 60 days label Oct 7, 2024
@github-actions github-actions bot closed this Oct 7, 2024
@epugh
Copy link
Contributor

epugh commented Oct 7, 2024

@HoustonPutman @magibney I'd be interested in working on the docs if this is still of interest to get this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-stale Closed after being stale for 60 days stale PR not updated in 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants