-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-10894: Update streaming parser to properly handle nested quotes #1781
SOLR-10894: Update streaming parser to properly handle nested quotes #1781
Conversation
Co-authored-by: Justin Sweeney <justinsweeney@fullstory.com>
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
Hey @magibney I have a change to make this just generic for any number of escapes of the quote. (for example if there was an escaped quote in a phrase query) Mind if I push to your branch? |
Co-authored-by: Houston Putman <houston@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but some documentation in the ref guide on how streaming expressions escaping happens would likely be useful!
This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the dev@solr.apache.org mailing list. Thank you for your contribution! |
This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. |
@HoustonPutman @magibney I'd be interested in working on the docs if this is still of interest to get this in? |
See: SOLR-10894