-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-16883: Use postlogs tool from windows and unix via solr cli infrastructure. #1786
Conversation
bats still passes...
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
@Willdotwhite @mkhludnev here is another one iwht changes to windows bin.cmd that owuld be nice to get independent test! |
Tested @epugh 👍🏻 - I've no idea what I just did, but it certainly did it: PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd postlogs -url http://localhost:8983/solr/gettingstarted -rootdir C:\Users\Will\Projects\solr\solr\packaging\build\dev\server\logs
Sending batch of 300 log records...
Batch sent
Sending batch of 300 log records...
...
Sending last batch ...
Batch sent
Committed |
The PS C:\Users\Will\Projects\solr\solr\packaging\build\dev\bin> .\solr.cmd postlogs -help
usage: postlogs
-help Print this message
-rootdir <arg> All files found at or below the root will be indexed.
-url <arg> Address of the collection, example
http://localhost:8983/solr/collection1/.
-verbose Enable more verbose command output. |
Sounds like a good idea to me. |
Terrific! Thanks for chiming in ;-). |
@Willdotwhite so yeah, I have been moving the detailed help over to the Ref Guide. Commons-cli doesn't make it easy to have a pretty/detailed "this is what the tool does", as far as I know. So that IS something we lose... |
@joel-bernstein I ran with it a bit and deprecated the SolrLogPostTool in favour of PostLogsTool and updated the ref guide as well in this PR. |
…astructure. (#1786) Postlogs tool only works on Linux, and was it's own implementation of a command line tool, with different patterns then the other tools. Migrate over to "bin/solr postlogs" and it now works like other CLI tools, including working on Windows.
https://issues.apache.org/jira/browse/SOLR-16883
Description
experimenting with making the postlogs tool part of SolrCLI so it runs on windows and unix and elminate custom shell scripting.
Let's see if we can't get more usage/awareness of Solr consuming Solr logs!
Solution
Similar to the SimplePostTool Approach...
Tests
ran bats, but need one for bin/solr postlogs
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.