Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update org.apache.logging.log4j:* to v2.24.1 #2047

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Oct 29, 2023

This PR contains the following updates:

Package Type Update Change
org.apache.logging.log4j:log4j-web (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-slf4j2-impl (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-layout-template-json (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-jul (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-core (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-api (source) dependencies minor 2.21.0 -> 2.24.1
org.apache.logging.log4j:log4j-1.2-api (source) dependencies minor 2.21.0 -> 2.24.1

Configuration

📅 Schedule: Branch creation - "* * * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@risdenk risdenk self-assigned this Nov 6, 2023
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 0818e1b to 5a53112 Compare December 8, 2023 09:58
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.21.1 Update org.apache.logging.log4j:* to v2.22.0 Dec 8, 2023
@solrbot
Copy link
Collaborator Author

solrbot commented Dec 8, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: undefined
Command failed: ./gradlew updateLicenses
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/home/ubuntu/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.23.1/9c15c29c526d9c6783049c0a77722693c66706e1/log4j-api-2.23.1.jar(/org/apache/logging/log4j/Level.class): warning: Cannot find annotation method 'value()' in type 'BaselineIgnore': class file for aQute.bnd.annotation.baseline.BaselineIgnore not found
error: warnings found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
1 warning

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':solr:test-framework:compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info option to get more log output.

BUILD FAILED in 29s

@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch 3 times, most recently from 69c78e8 to f514b6c Compare December 13, 2023 22:32
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from f514b6c to de4547b Compare December 27, 2023 16:26
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.22.0 Update org.apache.logging.log4j:* to v2.22.1 Dec 27, 2023
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from de4547b to d05ff94 Compare January 4, 2024 12:40
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from d05ff94 to 6802377 Compare February 15, 2024 09:21
@github-actions github-actions bot added the dependencies Dependency upgrades label Feb 15, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 6802377 to cd94764 Compare February 27, 2024 10:28
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.22.1 Update org.apache.logging.log4j:* to v2.23.0 Feb 27, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch 3 times, most recently from 9483105 to 609c35c Compare February 28, 2024 12:43
@janhoy
Copy link
Contributor

janhoy commented Feb 29, 2024

This upgrade was tricky. First, it did not compile unless upgrading biz.aQute.bnd to v7.0.0. After that, the build fails, complaining about class versions:

/home/runner/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.23.0/10741ddf9effd8e04d568148c2948a22f3f4cc73/log4j-api-2.23.0.jar(/org/apache/logging/log4j/Level.class): warning: Cannot find annotation method 'value()' in type 'BaselineIgnore': bad class file: /home/runner/.gradle/caches/modules-2/files-2.1/biz.aQute.bnd/biz.aQute.bnd.annotation/7.0.0/8ad279ebf0d04ea89c5ce4d934189d0d16bb6d50/biz.aQute.bnd.annotation-7.0.0.jar(/aQute/bnd/annotation/baseline/BaselineIgnore.class)
    class file has wrong version 61.0, should be 55.0

I cannot see that Log4j have officially announced that they require Java 17, although their release note page at https://logging.apache.org/log4j/2.x/release-notes.html says for the 2.22.1 release: "While maintaining compatibility with Java 8, the artifacts in this release where generated using JDK 17, unlike version 2.22.0 that used JDK 11.".

@uschindler Can you decode what they mean by this and whether this is likely a bug in the 2.23.0 release or if we cannot upgrade since they require java17?

PS: We should start thinking about JDK bump for Solr on main to at least 17.

@janhoy
Copy link
Contributor

janhoy commented Feb 29, 2024

I see from apache/logging-log4j2#2232 and other discussions that log4j now tells users to include Log4j as runtime scope, not compile scope, and not to interact programmatically with the library (like we do).

@janhoy janhoy marked this pull request as draft April 10, 2024 12:27
@janhoy
Copy link
Contributor

janhoy commented Apr 10, 2024

Unfortunate that we cannot upgrade due to requirement for Java 17 in a minor release... So will have to stick with the one we have I guess...

@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 6fc848c to 2664a2c Compare April 10, 2024 12:54
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.23.0 Update org.apache.logging.log4j:* to v2.23.1 Apr 10, 2024
@cpoerschke
Copy link
Contributor

Similar to #1821 i.e. blocked on JDK 17+ -- if I find a third solrbot PR like it I'll create a JIRA and then close out these in favour of that.

#1821 (comment)

@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 2664a2c to 6fbb82c Compare July 16, 2024 20:07
@solrbot
Copy link
Collaborator Author

solrbot commented Jul 16, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: undefined
Command failed: ./gradlew updateLicenses
SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
SLF4J(W): See https://www.slf4j.org/codes.html#noProviders for further details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /tmp/renovate/repos/github/apache/solr/solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/opt/containerbase/home/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.24.1/7ebeb12c20606373005af4232cd0ecca72613dda/log4j-api-2.24.1.jar(/org/apache/logging/log4j/Level.class): warning: Cannot find annotation method 'value()' in type 'BaselineIgnore': class file for aQute.bnd.annotation.baseline.BaselineIgnore not found
error: warnings found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error
1 warning
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':solr:test-framework:compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --info option to get more log output.

BUILD FAILED in 38s

@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch 3 times, most recently from b0f912f to 3705cc6 Compare July 19, 2024 16:20
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.23.1 chore(deps): update org.apache.logging.log4j:* to v2.23.1 Jul 22, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 3705cc6 to 9a459a8 Compare July 23, 2024 16:26
@solrbot solrbot changed the title chore(deps): update org.apache.logging.log4j:* to v2.23.1 Update org.apache.logging.log4j:* to v2.23.1 Jul 29, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 9a459a8 to 707baf8 Compare August 2, 2024 16:23
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.23.1 chore(deps): update org.apache.logging.log4j:* to v2.23.1 Aug 7, 2024
@solrbot solrbot changed the title chore(deps): update org.apache.logging.log4j:* to v2.23.1 Update org.apache.logging.log4j:* to v2.23.1 Aug 13, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from 707baf8 to cd545d9 Compare September 8, 2024 20:17
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.23.1 Update org.apache.logging.log4j:* to v2.24.0 Sep 8, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from cd545d9 to fe877ca Compare October 16, 2024 09:46
@solrbot solrbot changed the title Update org.apache.logging.log4j:* to v2.24.0 Update org.apache.logging.log4j:* to v2.24.1 Oct 16, 2024
@solrbot solrbot force-pushed the renovate/org.apache.logging.log4j branch from fe877ca to a10b608 Compare October 18, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependency upgrades
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants