-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-17481: Resolve use of -n flag in CLI commands #2745
Conversation
@malliaridis this is ready for review. I just removed "n" from RunExampleTool since it is not exposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing a PR so quickly. :)
Additional occurences that should be updated:
- solr/solr-ref-guide/modules/deployment-guide/pages/monitoring-with-prometheus-and-grafana.adoc - ~6 occurences of -n for --num-threads
- solr/dev-tools/scripts/cloud.sh - may be ignored, but uses -n for number of nodes
Going to ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me then. :)
(cherry picked from commit a4cc580)
https://issues.apache.org/jira/browse/SOLR-17481
Description
Deal with overlaps in flags
Solution
deprecate (9x) and remove (10.0) -n for defining the number of threads in SolrExporter
Remove -n for no-prompt in RunExampleTool (this option is not supported via bin/solr or bin/solr.cmd so no need to deprecate).
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.