-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager #2751
Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager #2751
Conversation
I haven't felt knowledgable enough to chime in much on this work, but I want to say how much I appreciate it! This is so exciting that we are finally getting the work done to move to our new clients! |
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientCloudManager.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Outdated
Show resolved
Hide resolved
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
} catch (SolrServerException e) { | ||
throw new IOException(e); | ||
} | ||
} | ||
|
||
private static final byte[] EMPTY = new byte[0]; | ||
|
||
@Override | ||
public byte[] httpRequest( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a reminder -- call this out in the commit message; we removed a public method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Outdated
Show resolved
Hide resolved
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Show resolved
Hide resolved
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientCloudManager.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 excellent
* Replaced CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager and updated all internal classes accordingly. * SolrCloudManager#httpRequest is removed. * Removed dependencies on Apache httpclient and httpcore from solrj-zookeeper --------- Co-authored-by: David Smiley <dsmiley@apache.org> (cherry picked from commit d0000b4)
* Replaced CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager and updated all internal classes accordingly. * SolrCloudManager#httpRequest is removed. * Removed dependencies on Apache httpclient and httpcore from solrj-zookeeper --------- Co-authored-by: David Smiley <dsmiley@apache.org> (cherry picked from commit d0000b4)
SOLR-16503
This PR removes CloudLegacySolrClient from SolrClientCloudManager and replaces it with CloudHttp2SolrClient. Additionally, all internal classes previously using CloudLegacySolrClient within SolrClientCloudManager have been updated to utilize CloudHttp2SolrClient.
I aim to refactor these implementations to use the abstract CloudSolrClient instead of the concrete class reference. This transition will provide better abstraction and maintainability moving forward.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.