Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager #2751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't felt knowledgable enough to chime in much on this work, but I want to say how much I appreciate it! This is so exciting that we are finally getting the work done to move to our new clients! |
dsmiley
reviewed
Oct 10, 2024
dsmiley
reviewed
Oct 10, 2024
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientCloudManager.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 10, 2024
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 10, 2024
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 10, 2024
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 10, 2024
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Show resolved
Hide resolved
dsmiley
reviewed
Oct 10, 2024
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
dsmiley
reviewed
Oct 10, 2024
| } catch (SolrServerException e) { | ||
| throw new IOException(e); | ||
| } | ||
| } | ||
|
|
||
| private static final byte[] EMPTY = new byte[0]; | ||
|
|
||
| @Override | ||
| public byte[] httpRequest( |
There was a problem hiding this comment.
a reminder -- call this out in the commit message; we removed a public method.
dsmiley
reviewed
Oct 12, 2024
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Outdated
Show resolved
Hide resolved
dsmiley
approved these changes
Oct 17, 2024
solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java
Show resolved
Hide resolved
epugh
reviewed
Oct 21, 2024
dsmiley
reviewed
Oct 21, 2024
solr/solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientCloudManager.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
.../solrj-zookeeper/src/java/org/apache/solr/client/solrj/impl/SolrClientNodeStateProvider.java
Outdated
Show resolved
Hide resolved
iamsanjay
added a commit
to iamsanjay/solr
that referenced
this pull request
Oct 24, 2024
* Replaced CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager and updated all internal classes accordingly. * SolrCloudManager#httpRequest is removed. * Removed dependencies on Apache httpclient and httpcore from solrj-zookeeper --------- Co-authored-by: David Smiley <dsmiley@apache.org> (cherry picked from commit d0000b4)
iamsanjay
added a commit
that referenced
this pull request
Oct 24, 2024
* Replaced CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager and updated all internal classes accordingly. * SolrCloudManager#httpRequest is removed. * Removed dependencies on Apache httpclient and httpcore from solrj-zookeeper --------- Co-authored-by: David Smiley <dsmiley@apache.org> (cherry picked from commit d0000b4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SOLR-16503
This PR removes CloudLegacySolrClient from SolrClientCloudManager and replaces it with CloudHttp2SolrClient. Additionally, all internal classes previously using CloudLegacySolrClient within SolrClientCloudManager have been updated to utilize CloudHttp2SolrClient.
I aim to refactor these implementations to use the abstract CloudSolrClient instead of the concrete class reference. This transition will provide better abstraction and maintainability moving forward.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.