Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17467: Finish migration to --user-managed mode #2781

Merged
merged 2 commits into from
Oct 21, 2024
Merged

SOLR-17467: Finish migration to --user-managed mode #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1e8701
Tighten test up to show that while we started, we aren't in cloud mode
epugh Oct 19, 2024
8ea4d1f
Flip boolean to fix start mode.
epugh Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion solr/core/src/java/org/apache/solr/cli/RunExampleTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ protected void runCloudExample(CommandLine cli) throws Exception {
// start the other nodes
for (int n = 1; n < numNodes; n++)
startSolr(
new File(cloudDir, "node" + (n + 1) + "/solr"), false, cli, cloudPorts[n], zkHost, 30);
new File(cloudDir, "node" + (n + 1) + "/solr"), true, cli, cloudPorts[n], zkHost, 30);
}

String solrUrl = (String) nodeStatus.get("baseUrl");
Expand Down
6 changes: 3 additions & 3 deletions solr/packaging/test/test_example_noprompt.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ teardown() {
solr stop --all >/dev/null 2>&1
}

@test "SOLR-16755 test works with --no-prompt" {
@test "start -e cloud works with --no-prompt" {
solr start -e cloud --no-prompt
solr assert --started http://localhost:${SOLR_PORT} --timeout 10000
solr assert --started http://localhost:${SOLR2_PORT} --timeout 10000
solr assert --started http://localhost:${SOLR_PORT} --cloud http://localhost:${SOLR_PORT} --timeout 10000
solr assert --started http://localhost:${SOLR2_PORT} --cloud http://localhost:${SOLR2_PORT} --timeout 10000
}
Loading