Evaluate nimbus.groups when nimbus.users is empty - #8998
Open
rzo1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleACLAuthorizer.permit()short-circuited onnimbusUsers.size() == 0and allowed the call, sonimbus.groupswas never consulted whennimbus.userswas left empty. An operator locking the cluster down by group alone therefore got no restriction at all.All four combinations are now evaluated; both-empty still means no restriction, which is the shipped default. Extends
SimpleACLAuthorizerTest.Note: a cluster that set
nimbus.groupswithoutnimbus.userswill now restrict user-level commands to members of those groups. That includesNimbusClient.getConfiguredClientAs, which callsgetLeader()on every connection.