[Relax] Enhance global var struct info update in BlockBuilder #17446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current BlockBuilder does not update the global var struct info after a function is updated. This commit enhances the BlockBuilder to update the global var struct info after a function is updated.
tqchen
approved these changes
Oct 8, 2024
tqchen
requested changes
Oct 8, 2024
| @@ -141,6 +130,8 @@ class BlockBuilderImpl : public BlockBuilderNode { | |||
| } | |||
|
|
|||
| context_mod_->Update(gv, function); | |||
| // Force update struct info | |||
| gv->struct_info_ = GetStructInfo(function); | |||
There was a problem hiding this comment.
one potential issue here is that the caller still relies on the assumption of previous function sigature, so automatically updating this may not always be desirable, is there any motivating usecase here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current BlockBuilder does not update the global var struct info after a function is updated. This commit enhances the BlockBuilder to update the global var struct info after a function is updated.