[YUNIKORN-2416] Cleanup replace directives #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Feb 22, 2024
| } | ||
|
|
||
| func SetLogLevel(level int) { | ||
| log.InitAndSetLevel(zapcore.Level(level)) |
There was a problem hiding this comment.
Could we rewrite this function by log.UpdateLoggingConfig?
There was a problem hiding this comment.
Just moved it back.
craigcondit
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Base on the discussion under apache/yunikorn-k8shim#794
and reference to the original Jira https://issues.apache.org/jira/browse/YUNIKORN-2416
Align the replace modules across projects:
For perf-tool,
What type of PR is it?
Todos
NA
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2416
How should this be tested?
Screenshots (if appropriate)
perf-tools completed:
CVE check passed:
Questions:
Please feel free to close it if yunikorn-release is not in the Jira scope.