Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build and deps #366

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Update build and deps #366

merged 4 commits into from
Sep 11, 2024

Conversation

tofu-rocketry
Copy link
Member

This PR updates a bunch of little things now that we no longer need Python 2 support. Mainly:

  • Update README
  • Update SPEC file so it stays mostly in step with new build script.
  • Update build script to remove Python 2 option.
  • Update min AMS library version in setup.py.

Resolves #216
Resolves #333

@tofu-rocketry tofu-rocketry added this to the 4.0.0 milestone Sep 11, 2024
@tofu-rocketry tofu-rocketry self-assigned this Sep 11, 2024
@tofu-rocketry tofu-rocketry marked this pull request as ready for review September 11, 2024 12:19
@tofu-rocketry tofu-rocketry requested a review from a team as a code owner September 11, 2024 12:19
gregcorbett
gregcorbett approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tofu-rocketry
Update README
7a85c62
@tofu-rocketry
Update dependency in spec file and set Python ver
538fadc
@tofu-rocketry
Remove Python 2 bits from build script
3a2b5c5 
- Also make the echo logging a bit clearer with spaces and markers.
- Remove uneeded comments.
- Add another space before in-line comments.
@tofu-rocketry
Add AMS version constraint to setup.py
a7486c6
@tofu-rocketry tofu-rocketry merged commit ed6501a into apel:dev Sep 11, 2024
10 of 12 checks passed
@tofu-rocketry tofu-rocketry deleted the update-build-and-deps branch September 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcorbett gregcorbett gregcorbett approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

EL9: attempt to use unversioned python Set min version of ams library (and others?)
2 participants
@tofu-rocketry @gregcorbett