Add absinthe_federation implementation #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdawgwilk
force-pushed
the
kaden/absinthe_federation
branch
from
ebd1203
to
26509b0
Compare
kdawgwilk
changed the title
kdawgwilk
force-pushed
the
kaden/absinthe_federation
branch
2 times, most recently
from
8b8ed6e
to
e2a78bf
Compare
kdawgwilk
force-pushed
the
kaden/absinthe_federation
branch
from
e2a78bf
to
9b142b0
Compare
kdawgwilk
changed the title
|
Was able to add support for multiple @key directives so let's wait until that merges DivvyPayHQ/absinthe_federation#23 |
kdawgwilk
force-pushed
the
kaden/absinthe_federation
branch
from
9b142b0
to
311d769
Compare
|
Alright that feature merged upstream so this is ready for review. We also have a draft for adding support for ftv1 but I would like to get it added to this list before that is done since it is a fairly large undertaking. |
|
@michael-watson I would love to get this merged before ElixirConf in 2 weeks, let me know if there is anything else you would like me to do |
kdawgwilk
force-pushed
the
kaden/absinthe_federation
branch
from
311d769
to
bd11e67
Compare
kdawgwilk
force-pushed
the
kaden/absinthe_federation
branch
from
bd11e67
to
cef024f
Compare
|
Thanks @kdawgwilk for your work on this! I'm really sorry it took me so long to get it reviewed, I'll be getting our public docs updated soon with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per request of @prasek in apollographql/federation#985 (comment) I am adding
absinthe_federationto the supported libraries listResolves DivvyPayHQ/absinthe_federation#17