CHORE Allow markdown component to open links in new tabs #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/appearherebloom/bloom/2sz1e9bxh |
lukeamarsh
approved these changes
Jan 23, 2020
illianyh
approved these changes
Jan 23, 2020
zlahham
approved these changes
Jan 23, 2020
svobom57
approved these changes
Jan 23, 2020
dbatten5
force-pushed
the
CHORE-update-markdown-component
branch
from
2876e89
to
1dcf9b3
Compare
dbatten5
force-pushed
the
CHORE-update-markdown-component
branch
from
1dcf9b3
to
f164815
Compare
dbatten5
force-pushed
the
CHORE-update-markdown-component
branch
from
f164815
to
a7b5c24
Compare
dbatten5
force-pushed
the
CHORE-update-markdown-component
branch
from
441fc04
to
f80e268
Compare
dbatten5
force-pushed
the
CHORE-update-markdown-component
branch
from
f80e268
to
98f89b0
Compare
Since the current markdown parsing package has a known issue with rendering inline html (rexxars/commonmark-react-renderer#9) which has been an issue for 3 years+, we need a new markdown package. The react-markdown package has an option to render links with target="_blank" so this commit allows the component to pass that option through
dbatten5
force-pushed
the
CHORE-update-markdown-component
branch
from
98f89b0
to
b2f0c8b
Compare
The test wasn't working with the updated `Markdown` component as it needs some special loader config to work with jest. Since the styleguide is no longer maintained and the `Introduction` component works fine on the styleguid page I've made the decision to skip the test for now.
svobom57
approved these changes
Jan 27, 2020
lukeamarsh
approved these changes
Jan 27, 2020
This was referenced Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the current markdown parsing package has a known issue with
rendering inline html (rexxars/commonmark-react-renderer#9) which
has been an issue for 3 years+, we need a new markdown package in order to render links which open in new tabs. The
react-markdownpackage has an option to render links withtarget="_blank"attribute and is well maintained, so this commit replaces the current package withreact-markdownand allows the component to pass that option through.