Revise empty file support for import public
#1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasvl
commented
Aug 29, 2024
CompileTests/MultiModule/Sources/ReExportAOnly/reexport_a_only.pb.swift
Outdated
Show resolved
Hide resolved
If the file defines no types, but it does have `import public` directives, then it still needs provide those imports so code only depending on this module gets the types.
thomasvl
force-pushed
the
empty_but_with_public_imports
branch
from
90d2e1c
to
42fee3e
Compare
allevato
approved these changes
Aug 29, 2024
gjcairo
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the file defines no types, but it does have
import publicdirectives, then it still needs provide those imports so code only depending on this module gets the types.