Add CompileTests for InternalImportsByDefault #1709
Conversation
| @@ -22,7 +22,7 @@ let package = Package( | |||
| .product(name: "SwiftProtobuf", package: "swift-protobuf"), | |||
| ], | |||
| swiftSettings: [ | |||
| .enableUpcomingFeature("InternalImportsByDefault"), | |||
| .enableExperimentalFeature("InternalImportsByDefault"), | |||
There was a problem hiding this comment.
I think you need to use AccessLevelOnImport and not use InternalImportsByDefault, the original issue with Foundation was because we didn't have an access level, so we don't want any level by default, but to ensure we're always providing level and to enable the support on these 5.x compilers.
There was a problem hiding this comment.
Thanks, I forgot to enable AccessLevelOnImport too. If InternalImportsByDefault is not enabled, we still get some default: it defaults to public instead. I came across this bug when having both features enabled.
There were also some issues with 5.8 not understanding these flags so I had to add some compiler guards but now finally CI is happy.
There was a problem hiding this comment.
What imports are still defaulting wrong? Do we need to fix those?
gjcairo
force-pushed
the
internal-imports-by-default-compile-tests
branch
from
15882c6
to
dad56cb
Compare
This PR adds a new CompileTest for checking that generated code builds successfully when
InternalImportsByDefaultis enabled.