Modified which() to support executables in workspace #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landrumb
force-pushed
the
which-landrumb
branch
from
1eeed2a
to
8340a98
Compare
dcdehaas
reviewed
Oct 8, 2024
| @@ -11,7 +11,7 @@ def which(exe: str, required=False) -> Optional[str]: | |||
| except subprocess.CalledProcessError: | |||
| result = None | |||
| if result is None: | |||
| for p in sys.path: | |||
| for p in [*sys.path, os.getcwd()]: | |||
There was a problem hiding this comment.
I think the challenge with this approach is that it will change which executables are used based on where the user is running the command from, which would probably lead to some very confusing behavior!
What about something like this?
THISDIR = os.path.dirname(os.path.realpath(__file__))
REPO_ROOT = os.path.join(THISDIR, "..", "..")
...
for p in [*sys.path, REPO_ROOT]:
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously only checking directories in PATH, added cwd as a directory to search.