Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Section is changed for the Hostel Management System . #1167

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

payalsinha12
Copy link
Contributor

@payalsinha12 payalsinha12 commented Jul 31, 2024

Title and Issue number

Title :About Section is changed for the Hostel Management System .

Issue No. : #1114

Code Stack : HTML , CSS

Close #1114

Video (mandatory)

https://drive.google.com/file/d/1SqC8K_XNboDqUdzHYKuTqAypXu6Bb1Eq/view?usp=sharing
#picture of the changes done
https://drive.google.com/file/d/11aErTYkNM3PShNpvd5GjB4JOp_Yne9g6/view?usp=sharing

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have gone through the contributing.md file before contributing

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a GSSOC'24 contributor
  • I'm a SSOC'24 contributor

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit 7885957
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/66acf58d1a208e0008ebac7b
😎 Deploy Preview https://deploy-preview-1167--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@payalsinha12
Copy link
Contributor Author

@apu52 please review it and merge it

@payalsinha12
Copy link
Contributor Author

@sanjay-kv please review it and merge it

@apu52
Copy link
Owner

apu52 commented Aug 1, 2024

@sanjay-kv please review it and merge it

Please don't tag Sanjay Sir here as he is the Project manger of GSSOC .Either tag me or @anuragverma108 (mentor) only

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The changes in the about section is good But the description is not proper . Please omit [PROJECT NAME] & fill the descriptions properly.

@apu52 apu52 added the help wanted Extra attention is needed label Aug 1, 2024
Copy link
Contributor Author

@payalsinha12 payalsinha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the changes and merge it @sanjay-kv @apu52

@payalsinha12
Copy link
Contributor Author

Screenshot 2024-08-02 203622
here's the updated about section

@payalsinha12
Copy link
Contributor Author

@sanjay-kv i am in SSOC not in GSSOC

@payalsinha12
Copy link
Contributor Author

@sanjay-kv please review it and merge it

Please don't tag Sanjay Sir here as he is the Project manger of GSSOC .Either tag me or @anuragverma108 (mentor) only

sorry for it

@sanjay-kv
Copy link
Collaborator

@payalsinha12 im program manager of GSSOC. Please don't tag me

@payalsinha12
Copy link
Contributor Author

@payalsinha12 im program manager of GSSOC. Please don't tag me

so sorry for it

@apu52 apu52 merged commit f0c1eaa into apu52:main Aug 2, 2024
4 checks passed
@apu52
Copy link
Owner

apu52 commented Aug 2, 2024

@payalsinha12 your changes are well made , but from next time please don't tag cautiously . Only tag me or @anuragverma108 from next time

@apu52 apu52 removed the help wanted Extra attention is needed label Aug 2, 2024
@apu52 apu52 added enhancement New feature or request SSOC Beginner labels Aug 2, 2024
@payalsinha12
Copy link
Contributor Author

@payalsinha12 your changes are well made , but from next time please don't tag cautiously . Only tag me or @anuragverma108 from next time

sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Want to enhance the about section of Hostel Management System
3 participants