Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alb security groups plugin #1555

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

alb security groups plugin #1555

wants to merge 9 commits into from

Conversation

abdullahaslam306
Copy link
Contributor

No description provided.

mehakseedat63
mehakseedat63 requested changes Jun 5, 2023
View reviewed changes
exports.js Outdated Show resolved Hide resolved
mehakseedat63
mehakseedat63 requested changes Jun 6, 2023
View reviewed changes
config_example.js Outdated Show resolved Hide resolved
mehakseedat63
mehakseedat63 requested changes Jun 6, 2023
View reviewed changes
plugins/aws/elbv2/albSecurityGroup.js Outdated

for (let alb of describeLoadBalancers.data){

if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue;
if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue;

This check will break if loadBalancerArn exists and type doesn't, is it supposed to be 'alb.Type && alb.Type.toLowerCase()'?

@abdullahaslam306
resolved
518a59d
@abdullahaslam306
Merge branch 'master' of https://github.com/aquasecurity/cloudsploit …
d3984fe 
…into feature/SAAS-14034-aws-ensure-application-load-balancers-are-associated-with-security-group
@alphadev4 alphadev4 added readytogo PRs ready to merge currentrelease and removed question labels Dec 5, 2023
@alphadev4 alphadev4 removed readytogo PRs ready to merge currentrelease labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehakseedat63 mehakseedat63 mehakseedat63 requested changes

@alphadev4 alphadev4 alphadev4 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdullahaslam306 @mehakseedat63 @alphadev4 @AkhtarAmir