Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alb security groups plugin #1555

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

abdullahaslam306
Copy link
Contributor

No description provided.

exports.js Outdated Show resolved Hide resolved
config_example.js Outdated Show resolved Hide resolved

for (let alb of describeLoadBalancers.data){

if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue;
if (!alb.LoadBalancerArn || (!alb.Type && alb.Type.toLowerCase() === 'application')) continue;

This check will break if loadBalancerArn exists and type doesn't, is it supposed to be 'alb.Type && alb.Type.toLowerCase()'?

…into feature/SAAS-14034-aws-ensure-application-load-balancers-are-associated-with-security-group
@alphadev4 alphadev4 added readytogo PRs ready to merge currentrelease and removed question labels Dec 5, 2023
@alphadev4 alphadev4 removed readytogo PRs ready to merge currentrelease labels Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants