Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmss app gateway enabled #1847

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdullahaslam306
Copy link
Contributor

No description provided.

@@ -4,7 +4,7 @@
"description": "AWS, Azure, GCP, Oracle, GitHub security scanning scripts",
"main": "index.js",
"scripts": {
"test": "mocha './**/*.spec.js'",
"test": "mocha './**/vmssApplicationGatewayEnabled.spec.js'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"test": "mocha './**/vmssApplicationGatewayEnabled.spec.js'",
"test": "mocha './**/*.spec.js'",

category: 'Virtual Machine Scale Set',
domain: 'Compute',
description: 'Ensures that Azure Virtual Machine scale sets has Application Gateway enabled.',
more_info: 'Tags help you to group resources together that are related to or associated with each other. It is a best practice to tag cloud resources to better organize and gain visibility into their usage.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be relevant to the plugin

link: 'https://learn.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-networking?tabs=portal1',
recommended_action: 'Modify VM scale set and add application gateway.',
apis: ['virtualMachineScaleSets:listAll'],

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add rt triggers

title: 'VM Scale Set Application Gateway Enabled',
category: 'Virtual Machine Scale Set',
domain: 'Compute',
description: 'Ensures that Azure Virtual Machine scale sets has Application Gateway enabled.',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think application gateway is not something that can be enabled. instead its something that we configure or add, so can you change the description and messages accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants