antimalware extension installed #1848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphadev4
requested changes
Jan 31, 2024
exports.js
Outdated
| @@ -1064,6 +1064,7 @@ module.exports = { | |||
| 'scalesetVTPMEnabled' : require(__dirname + '/plugins/azure/virtualmachinescaleset/scalesetVTPMEnabled.js'), | |||
| 'scalesetSecureBootEnabled' : require(__dirname + '/plugins/azure/virtualmachinescaleset/scalesetSecureBootEnabled.js'), | |||
| 'vmssApprovedExtensions' : require(__dirname + '/plugins/azure/virtualmachinescaleset/vmssApprovedExtensions'), | |||
| 'vmssWindowsAntiMalwareExtension': require(__dirname + '/plugins/azure/virtualmachinescaleset/vmssWindowsAntiMalwareExtension'), | |||
There was a problem hiding this comment.
can you shorten the filename? maybe rename it to vmssWindowsAntiMalwareExt
plugins/azure/virtualmachinescaleset/vmssWindowsAntiMalwareExtension.js
Outdated
Show resolved
Hide resolved
| category: 'Virtual Machines', | ||
| domain: 'Compute', | ||
| description: 'Ensures that Virtual Machine Scale Set windows instances have IaaS AntiMalware extension installed.', | ||
| more_info: 'The VM Scale Set Windows AntiMalware Extension provides real-time protection against viruses, spyware, and other malicious software for virtual machines running on the Windows operating system.', |
There was a problem hiding this comment.
Suggested change
| more_info: 'The VM Scale Set Windows AntiMalware Extension provides real-time protection against viruses, spyware, and other malicious software for virtual machines running on the Windows operating system.', | |
| more_info: 'The VM Scale Set Windows AntiMalware Extension provides real-time protection against viruses, spyware, and other malicious software for virtual machine scale sets running on the Windows operating system.', |
plugins/azure/virtualmachinescaleset/vmssWindowsAntiMalwareExtension.js
Outdated
Show resolved
Hide resolved
plugins/azure/virtualmachinescaleset/vmssWindowsAntiMalwareExtension.js
Outdated
Show resolved
Hide resolved
| : []; | ||
|
|
||
| if (!scaleSetExtensions.length) { | ||
| helpers.addResult(results, 2, 'No VMSS Extensions found', location); |
|
Meerab_shafique seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
alphadev4
approved these changes
Jan 31, 2024
mehakseedat63
requested changes
Feb 1, 2024
mehakseedat63
approved these changes
Mar 5, 2024
alphadev4
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.