Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PE-6058): fix signing issues with write interactions #60

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix(PE-6058): fix signing issues with write interactions #60

merged 2 commits into from
Apr 26, 2024

Conversation

dtfiedler
Copy link
Collaborator

@dtfiedler dtfiedler commented Apr 26, 2024 •
edited
Loading

Addressing #59

chore(tests): add tests that flag the verification issues
4c89149 
These will be the starting point for resolving the signing issues with warp
@dtfiedler dtfiedler changed the title chore(tests): add tests that flag the verification issues fix(PE-6058): fix signing issues with write interactions Apr 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (e2ad2b6) to head (0b558f5).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   80.62%   80.66%   +0.04%     
==========================================
  Files          19       19              
  Lines         449      450       +1     
  Branches       83       91       +8     
==========================================
+ Hits          362      363       +1     
+ Misses         87       86       -1     
- Partials        0        1       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtfiedler dtfiedler changed the base branch from main to alpha April 26, 2024 23:16
@dtfiedler dtfiedler marked this pull request as ready for review April 26, 2024 23:18
@dtfiedler dtfiedler requested a review from a team as a code owner April 26, 2024 23:18
@dtfiedler dtfiedler merged commit e1e7fac into alpha Apr 26, 2024
10 checks passed
@dtfiedler
Copy link
Collaborator Author

🎉 This PR is included in version 1.0.3-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler
Copy link
Collaborator Author

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dtfiedler dtfiedler linked an issue Apr 26, 2024 that may be closed by this pull request
[BUG] - Transaction failed verification on ArIO and ANT write interaction APIs #59
Closed
@dtfiedler dtfiedler deleted the PE-6058-verification-issues branch May 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atticusofsparta atticusofsparta atticusofsparta approved these changes

Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Transaction failed verification on ArIO and ANT write interaction APIs
3 participants
@dtfiedler @codecov-commenter @atticusofsparta