Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring and documentation expansion. #40

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Refactoring and documentation expansion. #40

merged 5 commits into from
Feb 1, 2024

Conversation

arbCoding
Copy link
Owner

Refactored code to split-up monolithic reading/writing functions (easier to maintain and document).

Expanded documentation for new functions and word position in SAC-files.

Migrated many for-loops to std::for_each.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ab96a8d1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab96a8d) Report Missing Report Missing Report Missing
Head commit (1fa48f1) 1384 1379 99.64%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#40) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b79730) 99.84% compared to head (1fa48f1) 99.63%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   99.84%   99.63%   -0.21%     
==========================================
  Files           2        2              
  Lines        1290     1384      +94     
==========================================
+ Hits         1288     1379      +91     
- Misses          2        5       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbCoding arbCoding merged commit 8f67e66 into main Feb 1, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant