-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change maximum UDP datagram buffer size #598
base: main
Are you sure you want to change the base?
Conversation
UDP packet will not send if its size is greater than 508, and the issue is hard to debug. I made this modification on my side and it works fine. Maybe add a warning if it is exceeded, instead of failing silently ?
Memory usage change @ cb81df2
Click for full report table
Click for full report CSV
|
@aqw42 Hi! I'm not sure I understand. You say "it works fine". Does that mean if you change the packet size it is sent successfully? It's a hardcoded value, so the user is not really supposed to change it. Can you elaborate? |
So, if you try to send anything biggest than this value (which is low for a udp datagram) the datagram will be truncated and there is no kind of warning or any way to let the developer know. I think a better solution would be implementing a mechanism of parametrisation of this at compile time, plus a way of preventing silent truncation of the datagram (warning at compile time ? Don't know if we can determine statically the size passed to the call) |
@aqw42 Got it. Thank you for clarifying. We'll look into it. |
UDP packet will not send if its size is greater than 508, and the issue is hard to debug. I made this modification on my side and it works fine. Maybe add a warning if it is exceeded, instead of failing silently ?